Do not drop extensions when merging a grouping Entry #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks Wen! |
aashaikh
reviewed
Dec 20, 2019
|
When can we expect this PR to be accepted? |
aashaikh
approved these changes
Jan 10, 2020
LeonGWang
added a commit
to aristanetworks/goyang
that referenced
this pull request
Jan 11, 2020
This commit mirrors PR openconfig#109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
mergefunction carries out the transplant of top-level nodes from a grouping to their target parent, extensions at the grouping level, which are stored at a temporary Entry to which the top-level nodes are attached before transplanting, are being dropped. This is because themergecode forgets about theExtsfield when it carries out the transplant operation.This change simply transplants the extensions as well to all the top-level nodes to make the transplant more complete.
See example #108
Fixes #108