Fix lexer to identify single-quote string that immediately occurs after a concatenation (plus sign). #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er a concatenation (plus sign). This code makes the new assumption that a `'` that follows `+` must be a string. This change will break YANG files where there exists an unquoted string that contains a `+'` character substring. Given that this is unlikely, I think this is a fine tradeoff to get cases like #180 working. Indeed, the current lexer is already assuming `"` cannot exist within an unquoted string (see `lexIdentifier`). This is already a much more restrictive assumption. NOTE: In YANG1.1: ``` An unquoted string cannot contain any single or double quote characters. ``` Fixes #180.
robshakir
approved these changes
Jun 19, 2021
wenovus
added a commit
that referenced
this pull request
Jul 28, 2021
@robshakir, I didn't do a merge on the older PRs before merging, leading to this breakage on HEAD. Is there a setting in goyang you can enable to make it similar ygot where you need to merge into master first before merge?
wenovus
added a commit
that referenced
this pull request
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code makes the new assumption that a
'that follows+must be a string.This change will break YANG files where there exists an unquoted string that contains a
+'character substring. Given that this is unlikely, I think this is a fine tradeoff to get cases like #180 working.Indeed, the current lexer is already assuming
"cannot exist within an unquoted string (seelexIdentifier). This is already a much more restrictive assumption.NOTE: In YANG1.1:
Fixes #180.