Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cluster #104

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Create cluster #104

merged 4 commits into from
Jan 31, 2022

Conversation

shubh90
Copy link
Contributor

@shubh90 shubh90 commented Jan 29, 2022

No description provided.

@coveralls
Copy link

coveralls commented Jan 29, 2022

Pull Request Test Coverage Report for Build 1768114197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.398%

Totals Coverage Status
Change from base Build 1758673022: 0.0%
Covered Lines: 1474
Relevant Lines: 2325

💛 - Coveralls


func (s *server) DeleteTopology(ctx context.Context, req *cpb.DeleteTopologyRequest) (*cpb.DeleteTopologyResponse, error) {
return nil, status.Errorf(codes.Unimplemented, "DeleteTopology RPC method not implemented.")
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't actually need any of these methods, the cpb.UnimplementedTopologyManagerService will automatically return what you've defined here for all un-specified methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return nil, status.Errorf(codes.Unimplemented, "DeleteTopology RPC method not implemented.")
}

func main() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main() should look something like this (the alts creds are required for directpath):

func main() {
	flag.Parse()
	addr := fmt.Sprintf(":%d", *port)
	lis, err := net.Listen("tcp6", addr)
	if err != nil {
		log.Fatalf("Failed to listen: %v", err)
	}
	creds := alts.NewServerCreds(alts.DefaultServerOptions())
	s := grpc.NewServer(grpc.Creds(creds))
	gpb.RegisterGNMIServer(s, &server{})
	log.Infof("Server listening at %v", lis.Addr())
	if err := s.Serve(lis); err != nil {
		log.Fatalf("Failed to serve: %v", err)
	}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shubh90 shubh90 merged commit 749bbb9 into main Jan 31, 2022
@alexmasi alexmasi deleted the create-cluster branch February 9, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants