Remote #108
Merged
Remote #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1808479743
💛 - Coveralls |
alexmasi
reviewed
Feb 7, 2022
deploy/deploy.go
Outdated
| {{end}} } | ||
| } | ||
| "auths": { | ||
| {{range $val := .}} "{{$val}}": {} |
There was a problem hiding this comment.
These additional spaces should be removed
deploy/deploy.go
Outdated
| @@ -451,4 +481,5 @@ func (m *MeshnetSpec) Healthy(ctx context.Context) error { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @@ -415,9 +447,7 @@ func (m *MeshnetSpec) SetKClient(c kubernetes.Interface) { | |||
| } | |||
|
|
|||
| func (m *MeshnetSpec) Deploy(ctx context.Context) error { | |||
| mPath := filepath.Join(deploymentBasePath, m.ManifestDir) | |||
| log.Infof("Deploying Meshnet from: %s", mPath) | |||
There was a problem hiding this comment.
Should probably keep this log line
| fakecorev1 "k8s.io/client-go/kubernetes/typed/core/v1/fake" | ||
| ktest "k8s.io/client-go/testing" | ||
| ) | ||
|
|
There was a problem hiding this comment.
there should probably be a deploy.Deploy test using all this fakes, maybe one simple success test case and one failure or something simple just so there is coverage of that important func
There was a problem hiding this comment.
So all of the methods in it like KindSpec, Metallb, Meshnet etc are unit tested already. I will get back to add this one more test after I finish the bigger implementations.
alexmasi
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.