Refactor node interface and implementation to allow for easier create / #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deletion of custom resources
shubh90
reviewed
Jul 15, 2021
| func (n *Node) CreateNodeResource(ctx context.Context, kClient kubernetes.Interface, ns string) error { | ||
| log.Infof("Create IxiaTG node resource %s\n", n.pb.Name) | ||
| func (n *Node) CreateNodeResource(ctx context.Context, ni node.Interface) error { | ||
| log.Infof("Create IxiaTG node resource %s", n.pb.Name) |
shubh90
reviewed
Jul 15, 2021
| log.Infof("Delete IxiaTG node resource %s\n", n.pb.Name) | ||
| err := kClient.CoreV1().RESTClient(). | ||
| func (n *Node) DeleteNodeResource(ctx context.Context, ni node.Interface) error { | ||
| log.Infof("Delete IxiaTG node resource %s", n.pb.Name) |
shubh90
reviewed
Jul 15, 2021
| @@ -124,7 +149,7 @@ func toEnvVar(kv map[string]string) []corev1.EnvVar { | |||
| return envVar | |||
| } | |||
|
|
|||
| func toResourceRequirements(kv map[string]string) corev1.ResourceRequirements { | |||
| func ToResourceRequirements(kv map[string]string) corev1.ResourceRequirements { | |||
There was a problem hiding this comment.
Should we add some docstring ? as this func is being exported now ?
shubh90
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deletion of custom resources