Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TopologyManager DeleteCluster method #121

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Add TopologyManager DeleteCluster method #121

merged 8 commits into from
Feb 22, 2022

Conversation

alexmasi
Copy link
Collaborator

  • method only supports kind clusters as of now
  • method returns appropriate grpc status codes to indicate if the cluster name does not exist or is not a kind cluster
  • fix logging

Tested: end-to-end with instance manager

@alexmasi alexmasi marked this pull request as ready for review February 18, 2022 23:59
@coveralls
Copy link

coveralls commented Feb 19, 2022

Pull Request Test Coverage Report for Build 1883658971

  • 0 of 41 (0.0%) changed or added relevant lines in 2 files are covered.
  • 111 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 60.183%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy/deploy.go 0 4 0.0%
controller/server/main.go 0 37 0.0%
Files with Coverage Reduction New Missed Lines %
topo/topo.go 111 40.88%
Totals Coverage Status
Change from base Build 1866422131: -0.6%
Covered Lines: 1779
Relevant Lines: 2956

💛 - Coveralls

controller/server/main.go Outdated Show resolved Hide resolved
controller/server/main.go Outdated Show resolved Hide resolved
@alexmasi alexmasi merged commit 632fe3c into main Feb 22, 2022
@alexmasi alexmasi deleted the cluster branch February 22, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants