Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShowCluster method implementation to TopologyManager #123

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Conversation

alexmasi
Copy link
Collaborator

  • generalize DeleteCluster to work with non-kind clusters
  • ShowCluster status check works for all cluster, cni, and ingress implementations
  • topology_names repeated field is currently not used, unclear how to provide this list. will add in a later PR if needed
  • Delete/ShowCluster only works for clusters created using CreateCluster. This is due to the extra deployment info stored during cluster creation such as ingress/cni/cluster type in order to perform relevant health checks and deletion

controller/server/main.go Outdated Show resolved Hide resolved
controller/server/main.go Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1890356033

  • 0 of 87 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 59.241%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controller/server/main.go 0 37 0.0%
deploy/deploy.go 0 50 0.0%
Files with Coverage Reduction New Missed Lines %
controller/server/main.go 2 48.85%
Totals Coverage Status
Change from base Build 1883689241: -0.9%
Covered Lines: 1779
Relevant Lines: 3003

💛 - Coveralls

@alexmasi alexmasi merged commit ea38d92 into main Feb 24, 2022
@alexmasi alexmasi deleted the manager branch February 24, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants