Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WithTopology() to create/delete/show topology in the Topology Manager #124

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

guoshiuan
Copy link
Collaborator

This PR also adds the following features:

  • Validate the topology protobuf in the request, e.g., whether router config path is valid.
  • Revise the unit test for topo.go

@guoshiuan guoshiuan requested a review from alexmasi March 1, 2022 00:26
@coveralls
Copy link

coveralls commented Mar 1, 2022

Pull Request Test Coverage Report for Build 1918183156

  • 31 of 103 (30.1%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 58.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
topo/topo.go 30 34 88.24%
controller/server/main.go 1 69 1.45%
Files with Coverage Reduction New Missed Lines %
controller/server/main.go 1 29.95%
Totals Coverage Status
Change from base Build 1894775456: -0.7%
Covered Lines: 1820
Relevant Lines: 3135

💛 - Coveralls

controller/server/main.go Outdated Show resolved Hide resolved
controller/server/main.go Show resolved Hide resolved
controller/server/main.go Outdated Show resolved Hide resolved
controller/server/main.go Outdated Show resolved Hide resolved
topo/topo.go Show resolved Hide resolved
topo/topo.go Show resolved Hide resolved
controller/server/main.go Outdated Show resolved Hide resolved
controller/server/main.go Outdated Show resolved Hide resolved
topo/topo.go Show resolved Hide resolved
controller/server/main.go Show resolved Hide resolved
@guoshiuan guoshiuan merged commit 606d419 into main Mar 1, 2022
@guoshiuan guoshiuan deleted the topo-fix branch March 1, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants