Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubecfg validation #125

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Fix kubecfg validation #125

merged 3 commits into from
Mar 2, 2022

Conversation

alexmasi
Copy link
Collaborator

@alexmasi alexmasi commented Mar 2, 2022

  • also use defaultTopoBasePath if the config path provided isn't absolute

@alexmasi alexmasi requested a review from guoshiuan March 2, 2022 16:43
@coveralls
Copy link

coveralls commented Mar 2, 2022 •
edited

Pull Request Test Coverage Report for Build 1923585177

  • 9 of 35 (25.71%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 57.733%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controller/server/main.go 9 35 25.71%
Files with Coverage Reduction New Missed Lines %
controller/server/main.go 4 27.27%
Totals Coverage Status
Change from base Build 1918543188: -0.3%
Covered Lines: 1818
Relevant Lines: 3149
💛 - Coveralls

guoshiuan
guoshiuan reviewed Mar 2, 2022
View reviewed changes
controller/server/main.go Outdated Show resolved Hide resolved
@alexmasi alexmasi merged commit 4fb633f into main Mar 2, 2022
@alexmasi alexmasi deleted the controller branch March 16, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexmasi @coveralls @guoshiuan