Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IxiaTG controller deployment #134

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Add IxiaTG controller deployment #134

merged 3 commits into from
Apr 11, 2022

Conversation

alexmasi
Copy link
Collaborator

@alexmasi alexmasi commented Apr 8, 2022

  • Adds ability to deploy the IxiaTG controller during kne_cli deploy cmd

Add the controllers field to the deployment yaml, optionally specify a custom configmap

e.g.

controllers:
  - kind: IxiaTG
    spec:
      manifests: ../../../keysight/athena/operator
controllers:
  - kind: IxiaTG
    spec:
      manifests: ../../../keysight/athena/operator
      configMap:
        release: 0.0.1-9999
        images:
          - name: controller
            path: some/path
            tag: latest
          - name: ...
          ...`

@coveralls
Copy link

coveralls commented Apr 8, 2022

Pull Request Test Coverage Report for Build 2150673899

  • 71 of 110 (64.55%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 57.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/deploy/deploy.go 12 14 85.71%
deploy/deploy.go 59 96 61.46%
Files with Coverage Reduction New Missed Lines %
deploy/deploy.go 2 64.41%
Totals Coverage Status
Change from base Build 2110560418: 0.2%
Covered Lines: 1871
Relevant Lines: 3237

💛 - Coveralls

cmd/deploy/deploy.go Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
deploy/deploy.go Show resolved Hide resolved
deploy/deploy.go Outdated Show resolved Hide resolved
@alexmasi alexmasi merged commit 1eb6e73 into main Apr 11, 2022
@alexmasi alexmasi deleted the controller branch April 11, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants