Cleanup presubmit #246
Merged
Cleanup presubmit #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Pull Request Test Coverage Report for Build 3333365663
💛 - Coveralls |
|
/gcbrun |
|
this will likely timeout due to loading of very large e8000 image |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
Presubmit has issue bringing up ceos node (same as b/254952420) |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
The included ondatra test will not be used in the presubmit until the config reset through ondatra knebind works as expected for all vendors (currently there are timeout issues) |
|
/gcbrun |
guoshiuan
reviewed
Oct 27, 2022
|
|
||
| import ( | ||
| // "context" | ||
| // "io" |
There was a problem hiding this comment.
Please remove the commented code.
guoshiuan
approved these changes
Oct 27, 2022
marcushines
pushed a commit
that referenced
this pull request
Jan 9, 2023
* Add ondatra test to presubmit * ignore non unit tests in check * use internal deployment config * lint * linter * linter * Linter * Use latest image for prototyping * Use presubmit-ready deployment * Cleanup test * Fix imports * Cleanup config in multivendor nokia * Fix multivendor topo * Fix flags for ondatra test * fix paths * Comment out unused code * lint * linter * Increase timeout of presubmit * specify a custom topology for presubmit * fix linter * reduce timeout * roll forward ondatra knebind * Use approved base image * increase machine size * persist inotify changes after reboot * Disable ondatra test until config reset is more stable * Fix watches to instances for inotify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.