Update Ixia for client api #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3340298137
💛 - Coveralls |
alexmasi
reviewed
Oct 21, 2022
topo/node/ixia/ixia.go
Outdated
| _, err = c.IxiaTG(n.Namespace).Create(ctx, crd) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
Removed those checks.
| Do(ctx). | ||
| Error() | ||
| log.Infof("Updating ixia CRD (desiredState=%s) ...", desiredState) | ||
| _, err = c.IxiaTG(n.Namespace).Update(ctx, unStrCRD, metav1.UpdateOptions{}) |
There was a problem hiding this comment.
can you add a comment here on why update is being used instead of create?
There was a problem hiding this comment.
Added comment for TopologySpecs and Create operations.
|
/gcbrun |
|
We had a breakage in the presubmit (that was fixed but is not included on this branch). Can you cherrypick that change or resync and merge it in? 6a700bf sorry about that |
|
I have resynced and merged. |
|
/gcbrun |
alexmasi
previously approved these changes
Oct 25, 2022
|
Looks like there are some merge conflicts, once those are fixed I can merge |
|
Resolved the go.sum conflict. |
|
there are still merge conflicts unfortunately |
|
okay I merged the other PR, ready to run the presubmit on this as well after the merge conflicts are resolved |
|
/gcbrun |
alexmasi
approved these changes
Oct 27, 2022
marcushines
pushed a commit
that referenced
this pull request
Jan 9, 2023
* Update Ixia for client api * Incorporated review comments * Cleaned go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of go client API for IxiaTG CRD instead of REST API.