Add reset config to nodes which support and add cli command #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1148945467
💛 - Coveralls |
alexmasi
previously approved these changes
Aug 19, 2021
cmd/topology/topology.go
Outdated
| } | ||
| ctx := cmd.Context() | ||
| t.Load(ctx) | ||
| var nodes []*node.Node |
There was a problem hiding this comment.
I think this should simplify this block a bit:
nodes := t.Nodes()
if len(args) > 1 {
n, err := t.Node(args[1])
if err != nil {
return err
}
nodes = []*node.Node{n}
}
cmd/topology/topology.go
Outdated
| } | ||
| nodes = append(nodes, n) | ||
| } | ||
| var resetable []node.Reseter |
There was a problem hiding this comment.
nit: resettable and later in the interface its resetter
alexmasi
previously approved these changes
Aug 19, 2021
alexmasi
reviewed
Aug 19, 2021
| return err | ||
| } | ||
| nodes = append(nodes, n) | ||
| } |
There was a problem hiding this comment.
This will add the specified node to the entire collection of nodes a second time.
There was a problem hiding this comment.
grr this why i didn't want to have that pattern
shubh90
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
kne_cli topology reset
to reset the configuration of the node to a default config
if no devices are provides all nodes in the topology will be attempted
--skip will skip nodes which don't support resetcfg but will continue through all nodes