Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Unittests for reset #33

Merged
merged 7 commits into from
Aug 25, 2021
Merged

add Unittests for reset #33

merged 7 commits into from
Aug 25, 2021

Conversation

marcushines
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 24, 2021 •
edited

Pull Request Test Coverage Report for Build 1164850322

  • 18 of 30 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 46.086%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/clientset/v1beta1/topology.go 0 12 0.0%
Totals Coverage Status
Change from base Build 1163380058: -2.5%
Covered Lines: 571
Relevant Lines: 1239
💛 - Coveralls

alexmasi
alexmasi previously approved these changes Aug 24, 2021
View reviewed changes
cmd/topology/topology.go Show resolved Hide resolved
cmd/topology/topology_test.go Outdated Show resolved Hide resolved
cmd/topology/topology_test.go Outdated Show resolved Hide resolved
cmd/topology/topology_test.go Show resolved Hide resolved
cmd/topology/topology_test.go Outdated Show resolved Hide resolved
cmd/topology/topology_test.go Show resolved Hide resolved
topo/topo.go Show resolved Hide resolved
topo/topo.go Show resolved Hide resolved
@marcushines marcushines merged commit 2f472eb into main Aug 25, 2021
@marcushines marcushines deleted the hines branch August 25, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmasi alexmasi alexmasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcushines @coveralls @alexmasi