Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollforward deps to fix postsubmit #503

Merged
merged 4 commits into from
Mar 15, 2024
Merged

rollforward deps to fix postsubmit #503

merged 4 commits into from
Mar 15, 2024

Conversation

alexmasi
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8299836084

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 66.483%

Files with Coverage Reduction New Missed Lines %
topo/node/arista/arista.go 1 70.12%
Totals Coverage Status
Change from base Build 8177959795: -0.02%
Covered Lines: 4336
Relevant Lines: 6522

💛 - Coveralls

@alexmasi
Copy link
Collaborator Author

looks good so far, still need to test kind and multinode with cri-dockerd bringup

@alexmasi alexmasi marked this pull request as ready for review March 15, 2024 17:08
@alexmasi alexmasi requested a review from guoshiuan March 15, 2024 17:08
@alexmasi alexmasi merged commit f197e16 into main Mar 15, 2024
9 checks passed
@alexmasi alexmasi deleted the builder branch March 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants