Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for host validation before Create #538

Merged
merged 2 commits into from
May 9, 2024
Merged

Check for host validation before Create #538

merged 2 commits into from
May 9, 2024

Conversation

DanG100
Copy link
Contributor

@DanG100 DanG100 commented May 8, 2024

No description provided.

@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9020607665

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 65.251%
Totals Coverage Status
Change from base Build 8993633325: 0.08%
Covered Lines: 4640
Relevant Lines: 7111
💛 - Coveralls

alexmasi
alexmasi reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@alexmasi alexmasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be deleted now:

kne/topo/node/node.go

Line 238 in 489aaeb

if err := n.ValidateConstraints(); err != nil {

@DanG100
Copy link
Contributor Author

DanG100 commented May 9, 2024

This can probably be deleted now:

kne/topo/node/node.go

Line 238 in 489aaeb

if err := n.ValidateConstraints(); err != nil {

done

@alexmasi
Copy link
Collaborator

alexmasi commented May 9, 2024

/gcbrun

@alexmasi alexmasi merged commit f22c301 into openconfig:main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmasi alexmasi alexmasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanG100 @coveralls @alexmasi