renamed srl controller repo and improved integration with srl-controller #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1328650291
💛 - Coveralls |
hellt
changed the title
marcushines
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo rename
due to a poorely chosen intial name of the srlinux controller repository, it has been decided to change it from
kne-controllertosrl-controllerThe repo that contains the controller code has been renamed and tagged with 0.2.0 version. This PR aligns
knewith these changes.I also used go17.2, where
go mod tidyapparently has changed the behaviour of imports...Enhanced SRL controller integration
As SR Linux controller code has reached 0.2.0 version, I have added support for image/model/vendor fields of the topology. Now it is possible to pass those values from the topo file and the controller will respect those.
The 3node-srl.pb.txt has been enhanced to demonstrate those options
/cc @marcushines