support for srlinux startup config provisioning #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1390332432
💛 - Coveralls |
mhines01
reviewed
Oct 27, 2021
| @@ -197,7 +204,8 @@ func defaults(pb *topopb.Node) *topopb.Node { | |||
| "type": topopb.Node_NOKIA_SRL.String(), | |||
| }, | |||
| Config: &topopb.Config{ | |||
| Image: "ghcr.io/nokia/srlinux:latest", | |||
| Image: "ghcr.io/nokia/srlinux:latest", | |||
| ConfigFile: "config.json", | |||
There was a problem hiding this comment.
what if a startup config isn't provided?
|
In that case the device will boot with the factory config.
Srl controller checks if the node has been defined in the topo file with
either data or file to proceed with looking for config map with startup
config
…On Thu, 28 Oct 2021 at 00:08, Marcus Hines ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In topo/node/srl/srl.go
<#76 (comment)>:
> @@ -197,7 +204,8 @@ func defaults(pb *topopb.Node) *topopb.Node {
"type": topopb.Node_NOKIA_SRL.String(),
},
Config: &topopb.Config{
- Image: "ghcr.io/nokia/srlinux:latest",
+ Image: "ghcr.io/nokia/srlinux:latest",
+ ConfigFile: "config.json",
what if a startup config isn't provided?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#76 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLKV5NB6OEUQM33SN3BVYDUJBZ6XANCNFSM5G2LRAWQ>
.
|
marcushines
approved these changes
Oct 27, 2021
marcushines
approved these changes
Oct 27, 2021
| EntryCommand: n.GetProto().GetConfig().GetEntryCommand(), | ||
| ConfigPath: n.GetProto().GetConfig().GetConfigPath(), | ||
| ConfigFile: n.GetProto().GetConfig().GetConfigFile(), | ||
| ConfigDataPresent: n.isConfigDataPresent(), |
There was a problem hiding this comment.
nit: testcase coverage for provided and not provided config?
|
nm not really worth it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcushines, I have added support for srl-labs/srl-controller to handle startup configuration instructions that kne users may provide in topo file srl-labs/srl-controller#4
Now when users have
file: "somepath"instruction under theconfigsection of a node, this file will be mounted as a startup config for srlinux node.The example with 3 nodes that I provided within this PR shows how node
r2uses just that.