Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bgp-set-med-type #839

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix bgp-set-med-type #839

merged 2 commits into from
Mar 28, 2023

Conversation

dplore
Copy link
Member

@dplore dplore commented Mar 27, 2023

Clarify the intended use of the types for bgp-set-med-type

This change is backwards compatible as no functionality is changed.

This change makes the `+` or `-` optional  in the string form of `bgp-set-med-type` , which is required to set the med directly as intended by this leaf.
@OpenConfigBot
Copy link

OpenConfigBot commented Mar 27, 2023

No major YANG version changes in commit f57682d

@OpenConfigBot
Copy link

OpenConfigBot commented Mar 27, 2023

Compatibility Report for commit f57682d:
yanglint@SO 1.10.17

Copy link

@swfrench swfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Darren!

@dplore dplore requested a review from chrisy March 28, 2023 00:01
@dplore dplore self-assigned this Mar 28, 2023
@aashaikh
Copy link
Contributor

Per offline followup, I don't believe we need this change -- i.e., the integer type in the set-med-type union should be used to set the MED value directly. The string should only be used when an increment/decrement expression is needed.

@dplore dplore requested a review from a team as a code owner March 28, 2023 16:09
@dplore dplore added the last-call PR that is in final review before merging. label Mar 28, 2023
Copy link
Contributor

@aashaikh aashaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update, LGTM.

@dplore dplore merged commit dec7eef into master Mar 28, 2023
@dplore dplore deleted the dplore/fix-bgp-med-type branch March 28, 2023 23:52
ruoyi-anet pushed a commit to ruoyi-anet/public that referenced this pull request Apr 6, 2023
* clarify intended use of bgp-set-med-type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call PR that is in final review before merging. non-breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants