Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure BFD min interval, multiplier when activated in protocols #856

Merged
merged 6 commits into from
Apr 30, 2024
Merged

Configure BFD min interval, multiplier when activated in protocols #856

merged 6 commits into from
Apr 30, 2024

Conversation

oscargdd
Copy link
Contributor

Change Scope

Min-tx-interval, required-minimum-receive and multiplier added for the case when BFD is activated at a protocol

Platform Implementations

Examples

Cisco

neighbor 10.10.10.2
     remote-as 65000
     bfd fast-detect
     bfd multiplier 3
     bfd minimum-interval 100

Juniper

neighbor 12.12.12.12 {
    description DESCRIPTION;
    import RP_BGP_IMPORT;
    authentication-key KEY;
    export RP_BGP_EXPORT;
    peer-as 65028;
    bfd-liveness-detection {
        minimum-interval 200
        multiplier 4
    }
}

Huawei

peer 10.10.10.10 as-number 65000
   peer 10.10.10.10 description DESCRIPTION
   peer 10.10.10.10 password PASSWORD
   peer 10.10.10.10 bfd min-tx-interval 200 min-rx-interval 200
   peer 10.10.10.10 bfd enable

@oscargdd
Added the options to configure BFD in protocols
b35c755 
Min-tx-interval, required-minimum-receive and multiplier added for the case when BFD is activated at a protocol
@oscargdd oscargdd requested a review from a team as a code owner April 13, 2023 16:30
@OpenConfigBot
Copy link

OpenConfigBot commented Apr 13, 2023 •
edited
Loading

No major YANG version changes in commit 9eafdbe

@OpenConfigBot
Copy link

OpenConfigBot commented Apr 13, 2023 •
edited
Loading

Compatibility Report for commit 966dd58:
⛔ yanglint@SO 1.10.17

dplore
dplore reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions for you

release/models/bfd/openconfig-bfd.yang Show resolved Hide resolved
release/models/bfd/openconfig-bfd.yang Show resolved Hide resolved
@dplore
Copy link
Member

dplore commented Apr 18, 2023

@s19nal to review

@oscargdd
Copy link
Contributor Author

New version uploaded following @dplore and @s19nal comments

@s19nal
Copy link

s19nal commented Nov 28, 2023

@oscargdd this all LGTM now sorry it has taken an age to get round to reviewing!

@dplore
Copy link
Member

dplore commented Jan 30, 2024

@oscargdd please include a pyang rendering of the tree, and resolve merge conflicts.

@dplore
Copy link
Member

dplore commented Mar 5, 2024

/gcbrun

1 similar comment
@dplore
Copy link
Member

dplore commented Apr 30, 2024

/gcbrun

@dplore dplore merged commit a2c7a09 into openconfig:master Apr 30, 2024
14 checks passed
@dplore dplore changed the title Configure BFD min interval, multipleir when activated in protocols Configure BFD min interval, multiplier when activated in protocols May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore left review comments

@jhaas-pfrc jhaas-pfrc jhaas-pfrc left review comments

@s19nal s19nal s19nal approved these changes

Assignees

@s19nal s19nal

Labels
non-breaking
Projects
OC Operator Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oscargdd @OpenConfigBot @dplore @s19nal @jhaas-pfrc