Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootz skip ownership check #908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xw-g
Copy link
Contributor

@xw-g xw-g commented Jul 11, 2023

Add the support of skipping ownership validation in Bootz.

There are 3 sequentially dependent PRs to introduce this changes.

  1. Bootz API PR updates Bootz API and README.
  2. [This PR] OC modeling PR updates Bootz OpenConfig modeling.
  3. FP test PR updates feature profile tests
module: openconfig-system-bootz

  augment /oc-sys:system:
    +--rw bootz
       +--rw config
       |  +--rw validate-ownership?   boolean <<<<<<<<<<<<<<<<<< new
       +--ro state
          +--ro checksum?              string
          +--ro error-count?           oc-yang:counter64
          +--ro status?                enumeration
          +--ro last-boot-attempt?     oc-types:timeticks64
          +--ro ownership-validated?   boolean <<<<<<<<<<<<<<<<<< new
          +--ro validate-ownership?    boolean <<<<<<<<<<<<<<<<<< new

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 11, 2023

Major YANG version changes in commit 4d00898:

@xw-g xw-g mentioned this pull request Jul 11, 2023
@xw-g xw-g requested review from marcushines and dplore July 11, 2023 18:20
@xw-g xw-g marked this pull request as ready for review July 11, 2023 18:38
@xw-g xw-g requested a review from a team as a code owner July 11, 2023 18:38
@dplore dplore self-assigned this Jul 12, 2023
Comment on lines +70 to +71
"This field controls if the device should validate the ownership in
the next bootz workflow";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"This field controls if the device should validate the ownership in
the next bootz workflow";
"This field controls if the device should validate the ownership
voucher as described in the bootz bootstrapping service API
flow.";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I denied your suggestions, because we need to call it out that it's for next bootz workflow that runs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was attempting to be more precise on two dimensions:

  • This leaf refers specifically to the bootz bootstrapping service which is a specific step within the bootz API Flow. (although admittedly, the bootz specification specifies a section header as API Flow but then also uses the words 'workflow' occasionally inside the API Flow section, I guess API Flow and Workflow are the same thing?).

  • This setting should be honored for every invocation of the bootstrapping service, not just the 'next' workflow? I guess since the configuration is persistent, the 'next' workflow could be considered all future workflows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent container is Bootz, so the all the leaves here is about the Bootz spec.

@github-actions github-actions bot added the Stale label May 9, 2024
@dplore
Copy link
Member

dplore commented Jun 4, 2024

@marcushines @xw-g do you want to continue with this PR? If yes please review

@github-actions github-actions bot removed the Stale label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

3 participants