Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change check #936

Merged
merged 59 commits into from
Aug 8, 2023
Merged

Add breaking change check #936

merged 59 commits into from
Aug 8, 2023

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Aug 1, 2023

The check fails if there is a backward-incompatible change that isn't accompanied by a major version update (if not at v0).
This check is not exhaustive, currently it checks for the following:

  • leaf deletion
  • leaf type change

There are other types of backward-incompatible changes not caught, e.g.

  • string pattern/number range restrictions becoming more restrictive.

Note: The "breaking"/"non-breaking" labels are still "dumb", i.e. they're determined by whether there are any major YANG version updates.

@OpenConfigBot
Copy link

OpenConfigBot commented Aug 1, 2023

No major YANG version changes in commit 098e81c

@OpenConfigBot
Copy link

OpenConfigBot commented Aug 1, 2023

Compatibility Report for commit 098e81c:
pyangbind@d122b7a

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

List of all YANG node changes

@wenovus wenovus changed the title Test CI Add backward-incompatibility check Aug 8, 2023
@wenovus wenovus changed the title Add backward-incompatibility check Add breaking change check Aug 8, 2023
@wenovus wenovus marked this pull request as ready for review August 8, 2023 17:13
cloudbuild.yaml Outdated Show resolved Hide resolved
@wenovus wenovus requested a review from a team as a code owner August 8, 2023 18:08
@wenovus wenovus requested a review from dplore August 8, 2023 19:39
@wenovus wenovus merged commit 0701ffe into master Aug 8, 2023
12 checks passed
@wenovus wenovus deleted the test-ci branch August 8, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants