Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge enum-moduledef to pick up #217 #219

Merged
merged 4 commits into from Aug 16, 2018
Merged

Merge enum-moduledef to pick up #217 #219

merged 4 commits into from Aug 16, 2018

Conversation

robshakir
Copy link
Contributor

Code approved in #217 -- merge was to the wrong branch.

 * (M) ygen/*
   - Fix a bug whereby if an identity was defined in a submodule
     its defining module would be identified as the submodule,
     rather than the parent module as is required by rfc6020.
* Debugging

* Working commit to resolve erroneous de-duplication.

* Update exampleoc with fixed generation of enum names.

* Update code generation tests, and resolve flake.

* Remove unused function; clean-up duplication; fn comment.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 91.08% when pulling 3ee5f6d on enum-moduledef into a70fc9a on master.

@robshakir
Copy link
Contributor Author

Force merging based on approval in #217.

@robshakir robshakir merged commit fbe8666 into master Aug 16, 2018
@robshakir robshakir deleted the enum-moduledef branch August 16, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants