Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour enum package name. #272

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Honour enum package name. #272

merged 1 commit into from
Feb 22, 2019

Conversation

robshakir
Copy link
Contributor 

 * (M) proto_generator/protogenerator.go
  - Fix bug whereby we did not honour the enum package name supplied
    to us -- fixes #271.

@robshakir
Honour enum package name.
035a46f 
 * (M) proto_generator/protogenerator.go
  - Fix bug whereby we did not honour the enum package name supplied
    to us -- fixes #271.
@robshakir robshakir mentioned this pull request Feb 22, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.203% when pulling 035a46f on enumpkgname into ff87766 on master.

@g-yusufsn g-yusufsn merged commit ce3ee58 into master Feb 22, 2019
@robshakir
Copy link
Contributor Author

Thanks @g-yusufsn!

@robshakir robshakir deleted the enumpkgname branch February 22, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-yusufsn g-yusufsn g-yusufsn approved these changes

@aashaikh aashaikh Awaiting requested review from aashaikh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robshakir @coveralls @g-yusufsn