Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go mod tidy check #903

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Add go mod tidy check #903

merged 5 commits into from
Aug 4, 2023

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Aug 1, 2023 •
edited

Fail if go mod tidy records a diff

@wenovus wenovus marked this pull request as ready for review August 1, 2023 18:10
@wenovus wenovus linked an issue Aug 1, 2023 that may be closed by this pull request
Make sure CI runs go mod tidy and notices no diffs. #898
Closed
@coveralls
Copy link

Coverage Status

coverage: 89.569%. remained the same when pulling ad1c8bd on mod-tidy-check into df0faa5 on master.

@wenovus wenovus merged commit 0731f55 into master Aug 4, 2023
8 checks passed
@wenovus wenovus deleted the mod-tidy-check branch August 4, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

@robshakir robshakir Awaiting requested review from robshakir

@Ankur19 Ankur19 Awaiting requested review from Ankur19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure CI runs go mod tidy and notices no diffs.
3 participants
@wenovus @coveralls @DanG100