Support mapping of protobuf lists. #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (M) protomap/{proto,proto_test.go}
- Support nested messages when unmarshalling protobufs, previously
such messages did not have their contents mapped.
* (M) protomap/integration_tests/integration_test.go
- Add a testcase for gRIBI's real protobufs to ensure that
unmarshalling is covered.
wenovus
reviewed
Sep 22, 2023
|
Thanks for the review, pushed an updated commit to address the comments. |
|
Upstream conflicts fixed. @wenovus - PTAL when you get a chance, thanks! |
wenovus
approved these changes
Sep 25, 2023
|
Thanks very much for the swift reviews Wen :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mapping protobuf
repeatedfields that represent YANG lists into protobuf messages. This was an unimplemented gap previously.The large change is due to changes in the testdata protobuf that is used for mapping.
There's a little bit of a
DIFFBASESNAFU here, where I pushed the initial PR from a fork, and this one is inopenconfig/ygot. The plan will be to merge #914 and then rebase this PR onto HEAD ofmaster.