Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support leaf-lists in paths->protobuf. #926

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Add support leaf-lists in paths->protobuf. #926

merged 6 commits into from
Nov 7, 2023

Conversation

robshakir
Copy link
Contributor 

 * (M) protomap/integration_tests/integration_test.go
  - Add test case for a failure that was causing a panic,
    where a leaf-list of union values was being handed to
    PathsToProto. Currently not yet implemented, but test
    checks error handling works as expected.
 * (M) protomap/proto(_test)?.go
  - Add support and testing for mapping of leaf-lists of
    YANG inbuilt types to protobufs.

@robshakir
Add support leaf-lists in paths->protobuf.
947750b 
 * (M) protomap/integration_tests/integration_test.go
  - Add test case for a failure that was causing a panic,
    where a leaf-list of union values was being handed to
    PathsToProto. Currently not yet implemented, but test
    checks error handling works as expected.
 * (M) protomap/proto(_test)?.go
  - Add support and testing for mapping of leaf-lists of
    YANG inbuilt types to protobufs.
@coveralls
Copy link

coveralls commented Nov 4, 2023 •
edited

Coverage Status

coverage: 89.613% (+0.1%) from 89.514%
when pulling d1fc01e on protomap-leaflist
into 7172fd7 on master.

@robshakir
Copy link
Contributor Author

Sorry for the PR length -- necessary to add test coverage for all edge cases.

wenovus
wenovus approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the test cases for the great coverage.

protomap/proto.go Outdated Show resolved Hide resolved
protomap/proto.go Show resolved Hide resolved
@robshakir
Add TODO.
7a7b21d
@robshakir
Throw an error for repeated in makeWrapper.
0d75462
@robshakir
Add support for mapping leaf-lists of unions to protobufs. (#927)
ae4bda6 
* Add support for mapping leaf-lists of unions to protobufs.

 * (M) integration_tests/integration_test.go
  - Reflect the fact that the gRIBI integration test cases is now
    implemented.
 * (M) protomap/proto.go
  - Add support for mapping both []any and gNMI TypedValue messages
    to fields within a protobuf from input gNMI paths.
 * (M) protomap/testdata/...
  - Additional fields in test protobufs.

* Add outdated file.

* Remove stale output.

* Improve test coverage - add handling for bool.
@robshakir
Merge branch 'master' into protomap-leaflist
d1fc01e
@robshakir robshakir merged commit 2fe7c7f into master Nov 7, 2023
10 checks passed
@robshakir robshakir deleted the protomap-leaflist branch November 7, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

@akrentsel akrentsel Awaiting requested review from akrentsel

@alshabib alshabib Awaiting requested review from alshabib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robshakir @coveralls @wenovus