Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for go 1.18. #968

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Remove support for go 1.18. #968

merged 1 commit into from
Apr 25, 2024

Conversation

robshakir
Copy link
Contributor

* (M) .github/workflows/go.yml
   - Remove testing support for go 1.18 -- these tests are failing
     based on dependencies. Our contract here is to support -3
     versions, so this is in-line with expecations of our consumers.

Fixes the failing CI @ HEAD.

 * (M) .github/workflows/go.yml
   - Remove testing support for go 1.18 -- these tests are failing
     based on dependencies. Our contract here is to support -3
     versions, so this is in-line with expecations of our consumers.
@robshakir robshakir requested a review from wenovus April 18, 2024 18:33
@coveralls
Copy link

Coverage Status

coverage: 88.811%. remained the same
when pulling 3f7a172 on go122
into a59697e on master.

.github/workflows/go.yml Show resolved Hide resolved
@wenovus wenovus merged commit 9cb751b into master Apr 25, 2024
11 checks passed
@wenovus wenovus deleted the go122 branch April 25, 2024 21:14
wenovus added a commit that referenced this pull request Apr 25, 2024
As reasoned in
#968 (comment)
This allows ygot to accept more security patches, and encourages
users to keep their own code up-to-date with the most secure Go
releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants