Skip to content

Commit

Permalink
fail CI if conformance fails
Browse files Browse the repository at this point in the history
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
  • Loading branch information
jdolitsky committed Apr 12, 2023
1 parent a5582e3 commit 18fdcbd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,8 @@ jobs:
echo "Found report.html."
echo "has-report=true" >> $GITHUB_OUTPUT
fi
# TODO: Fail with CONFORMANCE_RC if non-zero
# (conformance not yet passing for this registry)
echo "Conformance return code: ${CONFORMANCE_RC}"
exit 0
exit ${CONFORMANCE_RC}
- name: Upload OCI conformance results as build artifact
if: always() && steps.tests.outputs.has-report == 'true'
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,8 @@ jobs:
echo "Found report.html."
echo "has-report=true" >> $GITHUB_OUTPUT
fi
# TODO: Fail with CONFORMANCE_RC if non-zero
# (conformance not yet passing for this registry)
echo "Conformance return code: ${CONFORMANCE_RC}"
exit 0
exit ${CONFORMANCE_RC}
- name: Upload OCI conformance results as build artifact
if: always() && steps.tests.outputs.has-report == 'true'
Expand Down

0 comments on commit 18fdcbd

Please sign in to comment.