Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAG_INVALID in conformance tests is not present is spec #319

Closed
flavianmissi opened this issue Apr 1, 2022 · 2 comments · Fixed by #326
Closed

TAG_INVALID in conformance tests is not present is spec #319

flavianmissi opened this issue Apr 1, 2022 · 2 comments · Fixed by #326

Comments

@flavianmissi
Copy link
Contributor

The TAG_INVALID error code is currently being checked by the conformance tests, but it's not mentioned in the specification.

Should TAG_INVALID be added to the spec, or should it be removed from the comformance tests?

@sudo-bmitch
Copy link
Contributor

This was removed from the distribution-spec back in #206. Is this throwing an error for you? It may be useful for UX when interacting with registries that implement the docker registry spec.

@flavianmissi
Copy link
Contributor Author

No errors no. I thought I'd bring it up because although they are accepted error codes in the conformance tests, they are not listed in the list of acceptable error codes so I was a bit confused.
i.e

The code field MUST be one of the following:
Except the code can also be TAG_INVALID or MANIFEST_UNVERIFIED.

Am I nitpicking?

flavianmissi added a commit to flavianmissi/distribution-spec that referenced this issue May 12, 2022
Mentions `TAG_INVALID` and `MANIFEST_UNVERIFIED` as legacy error codes.

Also adjusts error codes' numbering - `code-11` got removed (by accident I assume).

Closes opencontainers#319

Signed-off-by: Flavian Missi <fmissi@redhat.com>
flavianmissi added a commit to flavianmissi/distribution-spec that referenced this issue May 12, 2022
Mentions `TAG_INVALID` and `MANIFEST_UNVERIFIED` as legacy error codes.

Also adjusts error codes' numbering - `code-11` was removed by
opencontainers#206.

Closes opencontainers#319

Signed-off-by: Flavian Missi <fmissi@redhat.com>
sudo-bmitch pushed a commit to sudo-bmitch/distribution-spec that referenced this issue Aug 18, 2023
Mentions `TAG_INVALID` and `MANIFEST_UNVERIFIED` as legacy error codes.

Also adjusts error codes' numbering - `code-11` was removed by
opencontainers#206.

Closes opencontainers#319

Signed-off-by: Flavian Missi <fmissi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants