New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini update 2: new table of contents #159
Conversation
It seemed like a good idea at first to reorganize things in a giant HTML comment, but it appears a failed strategy. Instead, going to piecemeal changes into spec.md itself, on the "reorg" branch. Then when everything ready, we can make a big PR from "reorg" onto "master". Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
This is a new table of contents for the spec, designed to add simplicity and organization. Existing content will later be moved into one of these sections, or removed entirely if considered superfluous. Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
…nto HEAD Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
@rchincha modified based on your suggestions, please take a look when you have a min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
old toc was simply derived from the contents.. we can revisit this after the content lands ...
before merging this one do we want to make a copy of spec.md over to spec-new.md? or copy spec.md to spec-v.0.1.md Just thinking out-loud. |
@mikebrow please see #160 (comment) Notice the target branch for this PR ( |
didn't notice that before thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
besides the indentation?
- [PATCH Blob Upload](#patch-blob-upload) | ||
- [PUT Blob Upload](#put-blob-upload) | ||
- [DELETE Blob Upload](#delete-blob-upload) | ||
- [Introduction](#introduction) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the indentation messed up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a new table of contents for the spec, designed to
add simplicity and organization.
Existing content will later be moved into one of these sections,
or removed entirely if considered superfluous.
This PR is built on top of #158, so the diff is misleading. Please see the following for a true diff: bloodorangeio/distribution-spec@mini-update-1...bloodorangeio:mini-update-2