Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-rc2 #253

Merged
merged 1 commit into from
Mar 31, 2021
Merged

1.0.0-rc2 #253

merged 1 commit into from
Mar 31, 2021

Conversation

jdolitsky
Copy link
Member

@jdolitsky jdolitsky commented Mar 24, 2021

Update 2021-03-31: Commit in description changed from f576ba2 to f8cd43f

this is for f8cd43f to be tagged as 1.0.0-rc2
Email vote forthcoming

14 PRs merged since v1.0.0-rc1:

(#249) Use unique blobs for each workflow category
(#246) Modify conformance tests for single-shot uploads
(#245) Replace references to 'master' with 'main'
(#239) Describe single-request monolithic upload behavior
(#233) Rewrite README based on image spec
(#223) Fixing broken content negotiation link in spec.md
(#221) Adding faq again to replace #189
(#220) update category requirement language
(#218) Add placeholder for content negotiation
(#217) Push image to GHCR on release or master update
(#209) spec: add missing TOOMANYREQUESTS (429) error-code
(#208) Add test and spec section for HEAD requests
(#206) Resolve several open issues
(#204) Add cross-repository mounting section to spec/test

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky marked this pull request as ready for review March 24, 2021 21:55
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Probably not urgent, as it doesn't affect the spec itself, but looking through the repo, I see we now have both the test suite (contributed by Kinvolk) and the conformance suite in this repository; IIUC, the conformance suite was to replace the test suite; per @vbatts comment on #39 (comment)

I want these changes to go in, for posterity sake. Even though the current consensus sounds like pulling in the conformance tests from the now-open-sourced projectquay is going to be our approach.

Wondering if the old one is still used, and if not, if this would be a good opportunity to clean up

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky mentioned this pull request Mar 25, 2021
@jdolitsky
Copy link
Member Author

@thaJeztah opened this issue and added to v1.0.0-rc3 milestone
#254

@jdolitsky jdolitsky merged commit da7f1c0 into opencontainers:main Mar 31, 2021
@thaJeztah
Copy link
Member

I doubt anyone is using it, but I saw that for previous releases, the version; in specs-go/version.go was updated (and tagged), after which is was moved back to -dev https://github.com/opencontainers/distribution-spec/blob/v1.0.0-rc1/specs-go/version.go#L20-L28

// VersionMajor is for an API incompatible changes
VersionMajor = 1
// VersionMinor is for functionality in a backwards-compatible manner
VersionMinor = 0
// VersionPatch is for backwards-compatible bug fixes
VersionPatch = 0
// VersionDev indicates development branch. Releases will be empty string.
VersionDev = "-rc1"

@jdolitsky
Copy link
Member Author

@thaJeztah - did not do it as part of this PR, but did do that again: 54a28c9

@thaJeztah
Copy link
Member

🙈 🙈 🙈 😞 oh!!! so sorry, I must've looked at this PR indeed, instead of at the tag and got confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants