Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index with subject conformance test #436

Merged

Conversation

sudo-bmitch
Copy link
Contributor

This adds a conformance test with an OCI index as an artifact with a subject field defined.

Fixes #434.

This is currently in draft pending a registry implementation that can be tested against it in CI.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch added this to the v1.1.0 milestone Jun 30, 2023
@sudo-bmitch
Copy link
Contributor Author

cc @rchincha

Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this passes now with zot 2.0 rc6!

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdolitsky jdolitsky merged commit e7db307 into opencontainers:main Jul 25, 2023
4 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-conformance-index-subject branch July 25, 2023 22:14
sudo-bmitch added a commit to sudo-bmitch/distribution-spec that referenced this pull request Aug 18, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
Co-authored-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky mentioned this pull request Jan 11, 2024
8 tasks
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance test needed for index with a subject
4 participants