Tag pagination #470
Tag pagination #470
Conversation
sudo-bmitch
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe and
vbatts
as code owners
sudo-bmitch
force-pushed
the
pr-tag-pagination
branch
2 times, most recently
from
b0b7fb0
to
ac58658
Compare
|
There is a proposal to replace this with #496. |
|
Why is this not merged after so many months? It's pretty obvious the current spec is broken and should be fixed. |
sudo-bmitch
force-pushed
the
pr-tag-pagination
branch
3 times, most recently
from
9610caf
to
2243be7
Compare
There was a problem hiding this comment.
Suggest avoiding promotion of the somewhat arbitrary number to a SHOULD value..
Also suggest allowing the maximum limit for the number of requests to be determined for a particular request.. Thus suggest not limiting with MUST language that a registry may have only one maximum limit.
sudo-bmitch
force-pushed
the
pr-tag-pagination
branch
from
654a2fd
to
c882c18
Compare
Updating tag listing to prefer the Link header. This aligns with the behavior of actual registries, but will break clients implementing the current spec. Breaking the spec was preferred over breaking existing registries and clients that work with them. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-tag-pagination
branch
from
c882c18
to
37a73f4
Compare
|
Documenting the community decision made today: We are making a breaking change to clients that followed the spec to document the majority of real world implementations. There are three different groups of clients to consider:
The community felt that the second group was larger than the first, and did not want to break those users even if it meant the first group would be silently broken. |
Registries must still support the n=100 and last query parameters. Clients may use the Link header.When registries cannot return all requested tags, an error must be returned.
This adds support for the Link header, and prefers it when available. Registries returning the Link header may return fewer than the requested number of tags per request.
Fixes #461.