README.md: Replace OCI scope table with OCI values #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqasimsarfraz
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
dmcgowan
previously approved these changes
Nov 20, 2023
mikebrow
requested changes
Nov 20, 2023
There was a problem hiding this comment.
While there is no scope table and the charter has been "simplified", this specification is still directed by the charter to adhere to the charter values..
https://github.com/opencontainers/tob/blob/main/CHARTER.md#7-oci-values
Suggest adding "- [OCI Values](https://github.com/opencontainers/tob/blob/main/CHARTER.md#7-oci-values)"
to the how this group operates list, located just above the removed text.
|
+1 non binding
…On Mon, Nov 20, 2023 at 12:05 PM Mike Brown ***@***.***> wrote:
***@***.**** requested changes on this pull request.
While there is no scope table and the charter has been "simplified", this
specification is still directed by the chart to adhere to the charter
values..
https://github.com/opencontainers/tob/blob/main/CHARTER.md#7-oci-values
Suggest adding "- OCI Values
<https://github.com/opencontainers/tob/blob/main/CHARTER.md#7-oci-values>
to the how this group operates list, located just above the removed text.
—
Reply to this email directly, view it on GitHub
<#493 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPSINDUAXZHCCA7G7NEJDYFOEUHAVCNFSM6AAAAAA7TEABPGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBQGMYDMMZXG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
--
Cheers,
Chris Aniszczyk
https://aniszczyk.org
|
The OCI scope table doesn't exist any more so drop the link. Similar to opencontainers/image-spec#824 Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
mqasimsarfraz
force-pushed
the
drop-scope-table-link
branch
from
0d76361
to
a88fed6
Compare
mqasimsarfraz
changed the title
|
@dmcgowan can you please review it again. I handled some comments! |
dmcgowan
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI scope table doesn't exist any more so drop the link. Similar to opencontainers/image-spec#824