Specify process for naming future architectures #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense to also have something like: New entries SHOULD be submitted to 1 for standardization. which is along the lines of what you had in 2. I agree with |
Signed-off-by: Timothy Hobbs <timothyhobbs@seznam.cz>
|
@wking improved the language, thanks. |
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 20, 2016
The old platform.os text had two MUST conditions. The first could have been read "the runtime MUST generate an error if invoked with a config.json whose platform.os is incompatible with the host platform" (which is the direction I'm going with this commit). However, it could also have been read "the bundle-validator MUST generate an error if platform.os is incompatible with the content the bundle's other content (e.g. 'linux' in platform.os, but only Windows binaries in the bundle's rootfs). For the second MUST, I doubt we want to require a compliant runtime support all Go architectures itself. And there is a benefit to pointing runtime/bundle authors at the Go set, but not much benefit in making that a hard limit [1,2]. The rewording here follows [2] in acknowledging that process.arch-matching is something that the config author and runtime caller have to sort out between themselves and pointing them at the Go docs and a registration process to avoid fragmenting the community. [1]: opencontainers/image-spec#29 [2]: opencontainers/image-spec#60 Signed-off-by: W. Trevor King <wking@tremily.us>
This was referenced May 20, 2016
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
The old platform.os text had two MUST conditions. The first could have been read "the runtime MUST generate an error if invoked with a config.json whose platform.os is incompatible with the host platform" (which is the direction I'm going with this commit). However, it could also have been read "the bundle-validator MUST generate an error if platform.os is incompatible with the content the bundle's other content (e.g. 'linux' in platform.os, but only Windows binaries in the bundle's rootfs). For the second MUST, I doubt we want to require a compliant runtime support all Go architectures itself. And there is a benefit to pointing runtime/bundle authors at the Go set, but not much benefit in making that a hard limit [1,2]. The rewording here follows [2] in acknowledging that process.arch-matching is something that the config author and runtime caller have to sort out between themselves and pointing them at the Go docs and a registration process to avoid fragmenting the community. [1]: opencontainers/image-spec#29 [2]: opencontainers/image-spec#60 Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothy Hobbs timothyhobbs@seznam.cz