Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected type/subtype test for descriptors should have comment that is failure #793

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Expected type/subtype test for descriptors should have comment that is failure #793

merged 1 commit into from
Jul 9, 2021

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Nov 6, 2019

Just kidding, I can't sleep at night because of these things :P

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

@vsoch
Copy link
Contributor Author

vsoch commented Nov 6, 2019

Looks like everything passed minus make .gitvalidation, here is from the makefile:

# When this is running in travis, it will only check the travis commit range
.gitvalidation:
	@which git-validation > /dev/null 2>/dev/null || (echo "ERROR: git-validation not found. Consider 'make install.tools' target" && false)
ifdef TRAVIS_COMMIT_RANGE
	git-validation -q -run DCO,short-subject,dangling-whitespace
else
	git-validation -v -run DCO,short-subject,dangling-whitespace -range $(EPOCH_TEST_COMMIT)..HEAD
endif

I'm not sure what this tool is, so let me know if I did something wrong on my end. I suspect the other PR test will fail too.

@cyphar
Copy link
Member

cyphar commented Dec 3, 2019

Same problem as #794 -- the commit message subject is too long. If you make it shorter the tests won't fail. As with the other PR, LGTM otherwise.

@vbatts
Copy link
Member

vbatts commented Dec 17, 2019

LGTM

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Dec 17, 2019

@cyphar same here regarding pattern-match on your approval

@vbatts
Copy link
Member

vbatts commented Jul 9, 2021

@vsoch could you rebase this?

…eferences failure, not success

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Contributor Author

vsoch commented Jul 9, 2021

@vbatts all set.

Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbatts vbatts merged commit d9aa673 into opencontainers:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants