Fixes #175 by referring to logrus by its lower-case name. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
175-logrus-lower-case-dependency
branch
from
3ccacd1
to
e1b84a3
Compare
|
Please follow the prompts to modify PR. |
|
@mgoltzsche please update. |
mgoltzsche
force-pushed
the
175-logrus-lower-case-dependency
branch
2 times, most recently
from
457a4aa
to
95bcf08
Compare
mgoltzsche
added a commit
to mgoltzsche/image-tools
that referenced
this pull request
Sep 15, 2017
References of github.com/Sirupsen/logrus have been rewritten to github.com/sirupsen/logrus to avoid case-insensitive import collisions when importing this project together with other projects that already refer to logrus using its lower-case package name. Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
References of github.com/Sirupsen/logrus have been rewritten to github.com/sirupsen/logrus to avoid case-insensitive import collisions when importing this project together with other projects that already refer to logrus using its lower-case package name. Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
mgoltzsche
force-pushed
the
175-logrus-lower-case-dependency
branch
from
95bcf08
to
4d03523
Compare
|
Whitespace removed. Sorry for the delay. |
|
LGTM |
|
ping @coolljt0725 |
|
cc @coolljt0725 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References of github.com/Sirupsen/logrus have been rewritten to
github.com/sirupsen/logrus to avoid case-insensitive import collisions when
importing this project together with other projects that already refer to
logrus using its lower-case package name.
logrus references have been updated manually in the following files:
glide updated some more files.
Build, lint and test have been run successfully.
Background: sirupsen/logrus#570 (comment)
Please be aware that this fix may cause problems in other projects that already use image-tools and still refer to github.com/Sirupsen/logrus but finally all projects that use the latter should be adjusted to use the lower-case name.
Signed-off-by: Max Goltzsche max.goltzsche@gmail.com