Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd cgroup drivers should not delegate everything to fs drivers #2436

Closed
kolyshkin opened this issue May 27, 2020 · 1 comment
Closed

Comments

@kolyshkin
Copy link
Contributor

Currently, systemd cgroup drivers (both v1 and v2) set systemd unit parameters (for those parameters that systemd supports), and then unconditionally fall back to fs driver, setting all the parameters again by writing to corresponding cgroup files.

There should be no such duplication, i.e. cgroup drivers should fall back to fs drivers only for parameters which are not supported by systemd. Otherwise, some discrepancies may occur, for example, systemd interprets cpu period and cpu quota in a specific manner, and most probably the configuration it sets is immediately overwritten by fs[2] driver.

A way to achieve this is to "unset" (set to 0) configs.Cgroup parameters that are used / known to systemd (in genV{1,2}ResourcesProperties).

@kolyshkin
Copy link
Contributor Author

Obsoleted by #4072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants