Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for container id naming #676

Closed
mikebrow opened this issue Mar 22, 2016 · 1 comment
Closed

Expand support for container id naming #676

mikebrow opened this issue Mar 22, 2016 · 1 comment

Comments

@mikebrow
Copy link
Member

Currently we limit container ids through regex to \w ascii numbers and letters and a few additional selected chars.

The spec has no such limit.

Suggest changing the code in one of the following ways to add the ability to support unicode names:

  1. do a touch cid to see if the OS supports it as a filename and report otherwise
  2. figure out how to the fix the expression for the plethora of unicode chars that should also be valid
  3. hash the passed in cid, store the original in the container's state.. (slow)
  4. @wrking suggestions: use percent-encoding or base64-encoding before using them as filenames

https://tools.ietf.org/html/rfc3986#section-2.1
http://tools.ietf.org/html/rfc4648#section-54

Opening the issue for discussion... I offer to do a PR based on discussions.

@mikebrow
Copy link
Member Author

mikebrow commented Apr 4, 2016

little interest shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant