Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: Shift the state tree to it's own set of files #143

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Contributor

@wking wking commented Sep 3, 2015

@crosbymichael was adding these to existing Go files to avoid having
a lot of files
. But 7232e4b (specs: introduce the concept of a
runtime.json, 2015-07-30, #88) split the runtime-configuration into
two file sets (one rooted in config.go for config.json and another
rooted in runtime_config.go for runtime.json). In the face of a
two-set split for a single task (feeding the runtime while it
manipulates the container lifecycle), it seems odd to push the type
definition for a completely different task (sharing
container/application state with other tools) into an existing file
set.

Spun off from here. See also #126, which standardizes the JSON /
doc / Go naming pattern.

Michael was adding these to existing Go files to avoid having a lot of
files [1].  But 7232e4b (specs: introduce the concept of a
runtime.json, 2015-07-30, opencontainers#88) split the runtime-configuration into
two file sets (one rooted in config.go for config.json and another
rooted in runtime_config.go for runtime.json).  In the face of a
two-set split for a single task (feeding the runtime while it
manipulates the container lifecycle), it seems odd to push the type
definition for a completely different task (sharing
container/application state with other tools) into an existing file
set.

[1]: opencontainers#87 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
@vbatts
Copy link
Member

vbatts commented Sep 4, 2015

I really don't see the need in having this struct split out at all :-\

@wking
Copy link
Contributor Author

wking commented Sep 4, 2015

On Fri, Sep 04, 2015 at 07:19:12AM -0700, Vincent Batts wrote:

I really don't see the need in having this struct split out at all :-\

There's no need, it's just consistent with the current config.go /
runtime_config.go split. I'd also be ok just moving everything into a
single file-set (e.g. spec.go and spec_linux.go) that contain all of
Spec, RuntimeSpec, and State (although then it's a bit harder to link
in from the Markdown docs to the appropriate section).

@crosbymichael
Copy link
Member

The files are small so I agree with @vbatts that we don't really need this type of split with the structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants