Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Run 'make fmt' #551

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Conversation

wking
Copy link
Contributor

@wking wking commented Aug 30, 2016

This should probably be part of our CI testing.

This should probably be part of our CI testing.

Signed-off-by: W. Trevor King <wking@tremily.us>
@vbatts
Copy link
Member

vbatts commented Aug 31, 2016

LGTM

Though CI would just do the formatting. It would need to check that it needs to be formatted

Approved with PullApprove

@wking
Copy link
Contributor Author

wking commented Aug 31, 2016

On Wed, Aug 31, 2016 at 08:17:33AM -0700, Vincent Batts wrote:

Though CI would just do the formatting. It would need to check that
it needs to be formatted

In an unrelated project and CI framework, I diff the original with the
auto-formatted version 1. And there's an earlier test for “is the
syntax valid?” 2. I can add something like that here (with a for
loop?) or put in in a separate PR if folks are interested.

@crosbymichael
Copy link
Member

crosbymichael commented Aug 31, 2016

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit d3c3763 into opencontainers:master Aug 31, 2016
@wking wking deleted the schema-format branch September 7, 2016 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants