Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "cc-runtime" to list of implementations. #922

Merged

Conversation

jodh-intel
Copy link
Contributor

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@caniszczyk
Copy link
Contributor

caniszczyk commented Sep 21, 2017

LGTM

Approved with PullApprove

Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this won't conflict with #883, so they can be landed in either order.

@@ -11,6 +11,7 @@ If you know of any associated projects that are not listed here, please file a p

* [hyperhq/runv][runv] - Hypervisor-based runtime for OCI
* [01org/cc-oci-runtime][cc-oci] - Hypervisor-based OCI runtime for Intel® Architecture
* [clearcontainers/runtime][cc-runtime] - Next-generation hypervisor-based OCI runtime for Intel® Architecture
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, what's the difference between cc-runtime and cc-oci-runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hqhq - I've now removed cc-oci-runtime as that project is now in maintenance mode.

cc-runtime is a complete rewrite in golang (under an Apache license rather than GPL). See the main page for further details.

"cc-runtime" replaces "cc-oci-runtime", which is now in maintenance
mode.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Contributor Author

Branch updated so may require a re-review.

@hqhq
Copy link
Contributor

hqhq commented Sep 22, 2017

LGTM

Approved with PullApprove

1 similar comment
@dqminh
Copy link
Contributor

dqminh commented Sep 22, 2017

LGTM

Approved with PullApprove

@dqminh dqminh merged commit f09dac8 into opencontainers:master Sep 22, 2017
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Sep 26, 2017
Through f09dac8 (Merge pull request opencontainers#922 from
jodh-intel/implementations-add-cc-runtime, 2017-09-22).

There have also been three non-spec changes which I have not
documented in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)
e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime"
  (opencontainers#922)

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking mentioned this pull request Sep 26, 2017
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Oct 4, 2017
Through 3417098 (Merge pull request opencontainers#913 from rutsky/fix-link,
2017-10-04).

There have also been a few non-spec changes which I have not
documented in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)
e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime"
  (opencontainers#922)
8a16f08 .mailmap: Consolidate James' entries (opencontainers#924)

Signed-off-by: W. Trevor King <wking@tremily.us>
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Oct 24, 2017
Through a5276ae (Merge pull request opencontainers#929 from
giuseppe/add-more-implementations, 2017-10-23).

There have also been a few non-spec changes which I have not
documented in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)
e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime"
  (opencontainers#922)
ec4cc47 implementations: add crun (opencontainers#929)
d4990d1 implementations: add bwrap-oci (opencontainers#929)
8a16f08 .mailmap: Consolidate James' entries (opencontainers#924)

Signed-off-by: W. Trevor King <wking@tremily.us>
vbatts pushed a commit to vbatts/oci-runtime-spec that referenced this pull request Oct 30, 2017
Through a5276ae (Merge pull request opencontainers#929 from
giuseppe/add-more-implementations, 2017-10-23).

There have also been a few non-spec changes which I have not
documented in the ChangeLog:

13b4639 .pullapprove.yml: Switch to v2 and other project-template
  updates (opencontainers#902)
f6f2514 README: Make meetings monthly (were weekly) (opencontainers#910)
e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime"
  (opencontainers#922)
ec4cc47 implementations: add crun (opencontainers#929)
d4990d1 implementations: add bwrap-oci (opencontainers#929)
8a16f08 .mailmap: Consolidate James' entries (opencontainers#924)

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants