Add pwalkdir, speed up chcon #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few non-scientific benchmarks (testdata is Linux kernel source tree, find is for reference only)
|
|
Nice! Will try to do a review soon, but ping me otherwise 😅 |
|
Awesome work @kolyshkin |
thaJeztah
requested changes
Aug 7, 2021
|
Looks like you forgot to remove some references that used the alias; |
This is a copy-paste implementation of pwalk but utilizing filepath.WalkDir instead (added in Go 1.16). As WalkDir do not call stat(2) on every entry, it is much (2x on my machine) faster than Walk (see below). The idea is to have pwalk and pwalkdir coexist for some time, then gradually retire pwalk once Go < 1.16 is unsupported. pwalk: BenchmarkWalk/Empty/filepath.Walk-4 50 24297251 ns/op BenchmarkWalk/Empty/pwalk.Walk-4 37 27564272 ns/op BenchmarkWalk/ReadFile/filepath.Walk-4 22 50904602 ns/op BenchmarkWalk/ReadFile/pwalk.Walk-4 37 30498257 ns/op BenchmarkWalk/ChownChmod/filepath.Walk-4 22 49689793 ns/op BenchmarkWalk/ChownChmod/pwalk.Walk-4 36 32384297 ns/op pwalkdir: BenchmarkWalk/Empty/filepath.WalkDir-4 96 12537753 ns/op BenchmarkWalk/Empty/pwalkdir.Walk-4 80 14289699 ns/op BenchmarkWalk/ReadFile/filepath.WalkDir-4 27 41524600 ns/op BenchmarkWalk/ReadFile/pwalkdir.Walk-4 50 24767977 ns/op BenchmarkWalk/ChownChmod/filepath.WalkDir-4 27 40676721 ns/op BenchmarkWalk/ChownChmod/pwalkdir.Walk-4 42 24256671 ns/op Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Using the newly added pwalkdir, the benchmark added by and described in commit ba956ca shows a considerable speed improvement (0.8s with pwalk, 0.5s with pwalkdir, 0.9s with chcon from GNU coreutils). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
🤦🏻 never trust 3am edits! Fixed. |
More than familiar with those 😂 |
|
@rhatdan ptal (CI wants 2 LGTMs, and the update invalidated your previous one 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: speed up chcon for up to 1.5x to 2x with Go 1.16+.
pkg/pwalkdir: add
This is a copy-paste implementation of pwalk but utilizing
filepath.WalkDir instead (added in Go 1.16). As WalkDir do not call
stat(2) on every entry, it is much (2x on my machine) faster than Walk
(see below).
The idea is to have pwalk and pwalkdir coexist for some time, then
gradually retire pwalk once Go < 1.16 is unsupported.
Chcon: speedup for Go 1.16+
Using the newly added pwalkdir, the benchmark added by and described
in commit ba956ca shows a considerable speed improvement
(0.8s with pwalk, 0.5s with pwalkdir, 0.9s with chcon from GNU coreutils).