Add interface to determine if selinux is enabled on the host. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
reviewed
Oct 26, 2017
| testUser := []string{"user:user_u", "role:user_r", "type:user_t", "level:s0:c1,c15"} | ||
| plabel, mlabel, err = InitLabels(testUser) | ||
| if err != nil { | ||
| t.Log("InitLabels User Failed") | ||
| t.Fatal(err) | ||
| } | ||
| if plabel != "user_u:user_r:user_t:s0:c1,c15" || (mlabel != "user_u:object_r:container_file_t:s0:c1,c15" && mlabel != "user_u:object_r:svirt_sandbox_file_t:s0:c1,c15") { | ||
| t.Log("InitLabels User Match Failed") | ||
| t.Log("InitLabels User Match Failed", plabel, mlabel) |
There was a problem hiding this comment.
you need Logf("InitLabels User Match Failed %s, %s", plabel, mlabel)
|
👍 |
|
Hold off on merging this, I am worried about another potential issue. |
|
Ok I fixed the issue, that I had added. Now a disabled container, does not disable all containers. :^( |
This will allow container runtimes to differentiate whether SELinux is disabled for the runtime versus disabled for the host system. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@rhatdan this still something you needed? If so, looks like this needs a rebase 😅 |
|
@thaJeztah it is so old, now that I think I will just close it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow container runtimes to differentiate whether SELinux is disabled
for the runtime versus disabled for the host system.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com