Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: working group for FreeBSD runtime #133

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Nov 10, 2023

With two working OCI runtimes for FreeBSD (runj, ocijail) and several container engines including containerd, podman and cri-o, there is a need to define a FreeBSD-specific section of the runtime-spec to allow support for platform features such as resource limits and fine-grained jail permissions. This will help to ensure runtime compatibility and build a consensus for the best way to support FreeBSD container runtimes.

@dch
Copy link

dch commented Nov 14, 2023

I'm also happy to help @dfr and @samuelkarp getting this done, in what ever way is required.

@dfr
Copy link
Contributor Author

dfr commented Nov 30, 2023

I made a minimal suggestion for a FreeBSD config extension here: https://github.com/dfr/runtime-spec/tree/freebsd-spec. This just allows setting a subset of the jail parameters to be used when creating a container jail.

@samuelkarp
Copy link
Member

@gtewallace Are there other members of the FreeBSD community who are interested in either being an owner or actively participating in the WG?

dfr added a commit to dfr/podman that referenced this pull request Dec 1, 2023
Right now, we always use a private UTS namespace on FreeBSD. This should
be made optional but implementing that cleanly needs a FreeBSD extension
to the OCI runtime config. The process for that is starting
(opencontainers/tob#133) but in the meantime,
assume that the UTS namespace is private on FreeBSD.

This moves the Linux-specific namespace logic to
container_internal_linux.go and adds a FreeBSD stub.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
dfr added a commit to dfr/podman that referenced this pull request Dec 1, 2023
Right now, we always use a private UTS namespace on FreeBSD. This should
be made optional but implementing that cleanly needs a FreeBSD extension
to the OCI runtime config. The process for that is starting
(opencontainers/tob#133) but in the meantime,
assume that the UTS namespace is private on FreeBSD.

This moves the Linux-specific namespace logic to
container_internal_linux.go and adds a FreeBSD stub.

Signed-off-by: Doug Rabson <dfr@rabson.org>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/podman that referenced this pull request Dec 1, 2023
Right now, we always use a private UTS namespace on FreeBSD. This should
be made optional but implementing that cleanly needs a FreeBSD extension
to the OCI runtime config. The process for that is starting
(opencontainers/tob#133) but in the meantime,
assume that the UTS namespace is private on FreeBSD.

This moves the Linux-specific namespace logic to
container_internal_linux.go and adds a FreeBSD stub.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
@mekanix
Copy link

mekanix commented Dec 5, 2023

me

@dfr
Copy link
Contributor Author

dfr commented Dec 5, 2023

me

owner or participant?

@mekanix
Copy link

mekanix commented Dec 5, 2023

Participant. Sorry for being vague.

@dfr
Copy link
Contributor Author

dfr commented Dec 5, 2023

Participant. Sorry for being vague.

Ok, I was just wondering whether or not to change the owners section of the WG proposal.

@gtewallace
Copy link

@gtewallace Are there other members of the FreeBSD community who are interested in either being an owner or actively participating in the WG?

Asking around. thanks!

@emaste
Copy link

emaste commented Dec 6, 2023

Just to confirm, I am happy with being listed as @dfr has done

@antranigv
Copy link

Me, as a participant. Commenting here as suggested by @dch

@mnour
Copy link

mnour commented Dec 7, 2023

I would like to join this WG as a participant.

@mateuszkwiatkowski
Copy link

Count me in as participant.

@joh-ku
Copy link

joh-ku commented Dec 8, 2023

I'd like to join as a participant as well and help wherever it is required.

@samuelkarp
Copy link
Member

samuelkarp commented Dec 12, 2023

Thanks everyone! Calling for a vote @opencontainers/tob:

2/3 vote is required, so 6/9 TOB members.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(non-binding)

proposals/wg-freebsd-runtime.md Outdated Show resolved Hide resolved
proposals/wg-freebsd-runtime.md Show resolved Hide resolved
proposals/wg-freebsd-runtime.md Outdated Show resolved Hide resolved
@dfr dfr force-pushed the freebsd branch 2 times, most recently from 7fac456 to 0d1192f Compare December 12, 2023 08:45
Signed-off-by: Doug Rabson <dfr@rabson.org>
Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧁🐐

@gtewallace
Copy link

Hi @cyphar quick ping to see if your concerns were addressed. tnx!

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-bmitch sudo-bmitch merged commit a65ae6b into opencontainers:main Dec 16, 2023
1 check passed
@sudo-bmitch
Copy link
Contributor

With 7/9 approvals, and 2 non-votes, this has passed. 🎉

@wolpert
Copy link

wolpert commented Dec 17, 2023

I would be interested in joining the WG as a participant.

@kchoudhu
Copy link

Would be happy to join as a participant as well.

@dfr
Copy link
Contributor Author

dfr commented Jan 19, 2024

Note for people interested in participating: there is a new github repository which we will use to coordinate: https://github.com/opencontainers/wg-freebsd-runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet