Merge 9b9212b into ba9fba3

opencor · Feb 22, 2019 · c7f852a · c7f852a
2 parents ba9fba3 + 9b9212b
commit c7f852a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/plugins/miscellaneous/Core/src/corecliutils.cpp b/src/plugins/miscellaneous/Core/src/corecliutils.cpp
@@ -325,16 +325,19 @@ QString fileSha1(const QString &pFileName)
 {
     // Return the SHA-1 value of the given file
 
+    QString res = QString();
     QFile file(pFileName);
 
     if (file.open(QFile::ReadOnly)) {
         QCryptographicHash hash(QCryptographicHash::Sha1);
 
         if (hash.addData(&file))
-            return hash.result();
+            res = hash.result();
+
+        file.close();
     }
 
-    return QString();
+    return res;
 }
 
 //==============================================================================

diff --git a/src/plugins/miscellaneous/HelpWindow/src/helpwindowwidget.cpp b/src/plugins/miscellaneous/HelpWindow/src/helpwindowwidget.cpp
@@ -182,8 +182,8 @@ HelpWindowWidget::~HelpWindowWidget()
 
     // Delete the help files
 
-    QFile(mQchFileName).remove();
-    QFile(mQhcFileName).remove();
+    QFile::remove(mQchFileName);
+    QFile::remove(mQhcFileName);
 }
 
 //==============================================================================