Make Clang-Tidy happy.

opencor · Oct 29, 2019 · d62d645 · d62d645
1 parent cb12482
commit d62d645
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/src/plugins/editing/CellMLTextView/src/cellmltextviewparser.cpp b/src/plugins/editing/CellMLTextView/src/cellmltextviewparser.cpp
@@ -194,7 +194,9 @@ bool CellmlTextViewParser::execute(const QString &pCellmlText,
     //       being referenced all over the place, which is really not what we
     //       want since that unnecessarily pollutes things...
 
-    for (const auto &key : mNamespaces.keys()) {
+    QStringList keys = mNamespaces.keys();
+
+    for (const auto &key : keys) {
         mDomDocument.documentElement().setAttribute(QString("xmlns:%1").arg(key), mNamespaces.value(key));
     }
 

diff --git a/src/plugins/miscellaneous/Core/src/centralwidget.cpp b/src/plugins/miscellaneous/Core/src/centralwidget.cpp
@@ -911,8 +911,8 @@ void CentralWidget::openRemoteFile(const QString &pUrl, bool pShowWarning)
                 hideBusyWidget();
 
                 warningMessageBox(tr("Open Remote File"),
-                                  tr("<strong>%1</strong> could not be opened (%2).").arg(fileNameOrUrl)
-                                                                                     .arg(formatMessage(errorMessage)));
+                                  tr("<strong>%1</strong> could not be opened (%2).").arg(fileNameOrUrl,
+                                                                                          formatMessage(errorMessage)));
             }
         }
     } else {

diff --git a/src/plugins/miscellaneous/Core/src/corecliutils.cpp b/src/plugins/miscellaneous/Core/src/corecliutils.cpp
@@ -994,7 +994,9 @@ QByteArray serialiseDomDocument(const QDomDocument &pDomDocument)
 
     // Manually serialise the elements' attributes
 
-    for (const auto &elementAttribute : elementsAttributes.keys()) {
+    QStringList elementAttributeKeys = elementsAttributes.keys();
+
+    for (const auto &elementAttribute : elementAttributeKeys) {
         res.replace(elementAttribute+R"(="")", elementsAttributes.value(elementAttribute));
     }
 

diff --git a/src/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewwidget.cpp b/src/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewwidget.cpp
@@ -750,7 +750,9 @@ void SimulationExperimentViewWidget::updateContentsInformationGui(SimulationExpe
         informationWidget->parametersWidget()->setColumnWidth(i, (i == iMax-1)?0:mParametersColumnWidths[i]);
     }
 
-    for (auto section : mGraphPanelSectionsExpanded.keys()) {
+    QIntList sectionKeys = mGraphPanelSectionsExpanded.keys();
+
+    for (auto section : sectionKeys) {
         informationWidget->graphPanelAndGraphsWidget()->setGraphPanelSectionExpanded(section, mGraphPanelSectionsExpanded.value(section));
     }
 }