Skip to content

Commit

Permalink
Merge 8085d15 into 3ff613d
Browse files Browse the repository at this point in the history
  • Loading branch information
agarny committed Aug 17, 2018
2 parents 3ff613d + 8085d15 commit edee6fd
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 11 deletions.
10 changes: 6 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,10 @@ set(BUILD_DIRECTORY_FILENAME ${PROJECT_BUILD_DIR}/builddirectory.txt)
file(WRITE ${SOURCE_DIRECTORY_FILENAME} "${CMAKE_SOURCE_DIR}")
file(WRITE ${BUILD_DIRECTORY_FILENAME} "${PROJECT_BUILD_DIR}")

keep_track_of_file(${SOURCE_DIRECTORY_FILENAME})
keep_track_of_file(${BUILD_DIRECTORY_FILENAME})
track_files(
${SOURCE_DIRECTORY_FILENAME}
${BUILD_DIRECTORY_FILENAME}
)

# Version/snapshot of OpenCOR

Expand All @@ -566,7 +568,7 @@ set(VERSION_DATE_FILENAME ${PROJECT_BUILD_DIR}/versiondate.txt)

file(WRITE ${VERSION_DATE_FILENAME} "${VERSION}\n${DATE}")

keep_track_of_file(${VERSION_DATE_FILENAME})
track_files(${VERSION_DATE_FILENAME})

# Configure our help file

Expand Down Expand Up @@ -755,7 +757,7 @@ if(ENABLE_TESTS)

file(WRITE ${TESTS_LIST_FILENAME})

keep_track_of_file(${TESTS_LIST_FILENAME})
track_files(${TESTS_LIST_FILENAME})

# Destination tests directory
# Note: DEST_TESTS_DIR isn't only used here, but also in our add_plugin()
Expand Down
12 changes: 7 additions & 5 deletions cmake/common.cmake
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
macro(keep_track_of_file FILE_NAME)
# Keep track of the given file
macro(track_files)
# Keep track of the given files
# Note: indeed, some files (e.g. versiondate.txt) are 'manually' generated
# and then used to build other files. Now, the 'problem' is that
# Ninja needs to know about those files (see CMake policy CMP0058),
# which we ensure it does through the below...

add_custom_command(OUTPUT ${FILE_NAME}
COMMAND ${CMAKE_COMMAND} -E sleep 0)
foreach(FILENAME ${ARGN})
add_custom_command(OUTPUT ${FILENAME}
COMMAND ${CMAKE_COMMAND} -E sleep 0)
endforeach()
endmacro()

#===============================================================================
Expand Down Expand Up @@ -36,7 +38,7 @@ macro(update_language_files TARGET_NAME)
-qm ${QM_FILE}
OUTPUT_QUIET)

keep_track_of_file(${QM_FILE})
track_files(${QM_FILE})
endif()
endforeach()
endmacro()
Expand Down
6 changes: 4 additions & 2 deletions src/plugins/miscellaneous/HelpWindow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ execute_process(COMMAND ${QT_BINARY_DIR}/qcollectiongenerator ${PROJECT_BUILD_DI
-o ${PROJECT_BUILD_DIR}/${CMAKE_PROJECT_NAME}.qhc
OUTPUT_QUIET)

keep_track_of_file(${PROJECT_BUILD_DIR}/${CMAKE_PROJECT_NAME}.qch)
keep_track_of_file(${PROJECT_BUILD_DIR}/${CMAKE_PROJECT_NAME}.qhc)
track_files(
${PROJECT_BUILD_DIR}/${CMAKE_PROJECT_NAME}.qch
${PROJECT_BUILD_DIR}/${CMAKE_PROJECT_NAME}.qhc
)

# Add the plugin

Expand Down

0 comments on commit edee6fd

Please sign in to comment.