Skip to content

Commit

Permalink
Simulation support: label an unsupported issue as being a piece of in…
Browse files Browse the repository at this point in the history
…formation (#2493).
  • Loading branch information
agarny committed Jun 30, 2021
1 parent 12fe307 commit fce21ef
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 15 deletions.
6 changes: 3 additions & 3 deletions src/plugins/support/PythonSupport/tests/data/basictests.out
Expand Up @@ -737,7 +737,7 @@
- Check simulation:
- Valid: no
- Issues:
- Unsupported: only SED-ML files with the same values for 'initialTime' and 'outputStartTime' are supported.
- Information: only SED-ML files with the same values for 'initialTime' and 'outputStartTime' are supported.

---------------------------------------------------------------------
Unsupported local SED-ML file (algorithm)
Expand All @@ -746,7 +746,7 @@
- Check simulation:
- Valid: no
- Issues:
- Unsupported: unsupported algorithm (KISAO:0000029).
- Information: unsupported algorithm (KISAO:0000029).

---------------------------------------------------------------------
Unsupported local SED-ML file (algorithm parameter)
Expand All @@ -755,4 +755,4 @@
- Check simulation:
- Valid: no
- Issues:
- Unsupported: unsupported algorithm parameter (KISAO:0000219).
- Information: unsupported algorithm parameter (KISAO:0000219).
Expand Up @@ -77,9 +77,5 @@
<source>the requested curve (%1) could not be set (the variable %2 in component %3 could not be found).</source>
<translation>la courbe demandée (%1) n&apos;a pas pu être spécifiée (la variable %2 dans le composant %3 n&apos;a pas pu être trouvée).</translation>
</message>
<message>
<source>Unsupported</source>
<translation type="unfinished"></translation>
</message>
</context>
</TS>
2 changes: 1 addition & 1 deletion src/plugins/support/SimulationSupport/src/simulation.cpp
Expand Up @@ -91,7 +91,7 @@ QString SimulationIssue::typeAsString() const
case Type::Fatal:
return QObject::tr("Fatal");
case Type::Unsupported:
return QObject::tr("Unsupported");
return QObject::tr("Information");
}

return "???";
Expand Down
4 changes: 0 additions & 4 deletions src/plugins/widget/EditorWidget/i18n/EditorWidget_fr.ts
Expand Up @@ -74,10 +74,6 @@
<source>Fatal</source>
<translation>Fatal</translation>
</message>
<message>
<source>Unsupported</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>OpenCOR::EditorWidget::EditorWidgetFindReplaceWidget</name>
Expand Down
5 changes: 2 additions & 3 deletions src/plugins/widget/EditorWidget/src/editorlistwidget.cpp
Expand Up @@ -58,7 +58,6 @@ EditorListItem::EditorListItem(Type pType, int pLine, int pColumn,
static const QIcon HintIcon = QIcon(":/oxygen/actions/help-hint.png");
static const QIcon InformationIcon = QIcon(":/oxygen/actions/help-about.png");
static const QIcon FatalIcon = QIcon(":/oxygen/actions/edit-bomb.png");
static const QIcon UnsupportedIcon = QIcon(":/oxygen/emotes/face-sad.png");

if ((pLine == -1) && (pColumn == -1)) {
if (pFileInfo.isEmpty()) {
Expand Down Expand Up @@ -113,7 +112,7 @@ EditorListItem::EditorListItem(Type pType, int pLine, int pColumn,

break;
case Type::Unsupported:
setIcon(UnsupportedIcon);
setIcon(InformationIcon);

break;
}
Expand Down Expand Up @@ -357,7 +356,7 @@ void EditorListWidget::copyToClipboard()

break;
case EditorListItem::Type::Unsupported:
itemType = tr("Unsupported");
itemType = tr("Information");

break;
}
Expand Down

0 comments on commit fce21ef

Please sign in to comment.